On Thu, Sep 24, 2009 at 10:30:33PM +0200, Rafael J. Wysocki wrote: > On Thursday 24 September 2009, Anton Vorontsov wrote: > > Following trace pops up if we try to suspend with 3c59x ethernet NIC > > brought down: > > Patch looks good, but IMO it'd be a little effort to convert the driver to > dev_pm_ops while you're at it (please see r8169 for a working example). I'd like to avoid putting irrelevant stuff into bugfixes. Apart from delights as bisecting and revert-only-offending-piece, keeping bugfixes small and self-sufficient helps to back-port the fixes to stable/distro kernels. Think of not so old kernels that don't have dev_pm_ops. Converting this driver (and others that I'm interested in) to dev_pm_ops is on my todo list though. Thanks, -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
