On Tue, Sep 22, 2009 at 2:50 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
On Tuesday 22 September 2009, Andreas Mohr wrote:
> Hi Rafael,
Hi,
I don't quite understand your comment, care to elaborate?
> first you say "returning an error code in such cases would..."
> and then the patch content has...?
I think this is what was being referenced:
+ /* Return error code if we have failed to change the state */
+ if (dev->current_state != state)
+ dev_info(&dev->dev, "Refused to change power state, "
+ "currently in D%d\n", dev->current_state);
The comment says, "Return error code", where it should probably say, "Log error". Or possibly no comment at all.
-Kevin Granade
+ /* Return error code if we have failed to change the state */
+ if (dev->current_state != state)
+ dev_info(&dev->dev, "Refused to change power state, "
+ "currently in D%d\n", dev->current_state);
The comment says, "Return error code", where it should probably say, "Log error". Or possibly no comment at all.
-Kevin Granade
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
