On Saturday 25 July 2009, Dmitry Torokhov wrote: > Hi Arnaud, > > On Sat, Jul 25, 2009 at 09:04:51AM -0400, Arnaud Faucher wrote: > > Gets rid of the following warning: > > Platform driver 'acer-wmi' needs updating - please use dev_pm_ops > > > > Have you tested it with Suspend to disk? You are [potentially] breaking > it since the new suspend and resume methods are not used by it, it calls > freeze() and thaw() instead. > > Rafael, > > I wonder if PM core should automatically use suspend()/resume() in place of > freeze()/thaw() when the latter pair is missing. Well, in fact it often is not necessary to do .thaw() at all, because the state of the device doesn't change in .freeze(). Also, PCI drivers should not need .thaw(), unless they manipulate the standard PM registers of the device themselves. That said, if .suspend() is defined, then most probably .freeze() is necessary as well. Also, if .resume() is defined, .restore() is most probably necessary and it should be safe to use .suspend() as .freeze() and .resume() as .restore(). OTOH, it's really easy to point .restore() to the same routine as .resume() etc., so I'm not sure. Best, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
