On Tuesday 09 June 2009, Oliver Neukum wrote: > Am Montag, 8. Juni 2009 20:34:30 schrieb Rafael J. Wysocki: > > On Monday 08 June 2009, Oliver Neukum wrote: > > > Am Montag, 8. Juni 2009 13:29:26 schrieb Rafael J. Wysocki: > > > > Secondly, you are not using a counter. Therefore only one driver can > > > control the PM state of a device at a given time. Is that wise? > > > > I didn't think about it to be honest. Obviously this patch doesn't cover > > all of the possible cases and I'm not even sure it's worth trying to cover > > them upfront. > > I am thinking of multimedia cards, which have separate drivers for i2c, tuner > and so on. Hmm, OK there. But there's only one bus type per device anyway, isn't it? So I'm not sure how a counter can help in this case. > > > Why is this needed? > > > > In some subsystems, like PCI, devices will be resumed by the BIOS > > unconditionally in the majority of cases and then it's not worth trying to > > complete run-time PM requests from before the suspend. > > But why is it worth canceling them? That feature seems to be an unnecessary > complication. As long as you can safely suspend them, why not do it? Because that's an operation that need not be necessary. I'd like to avoid unnecessary operations, but you're right, it can be done differently. > > > > +/** > > > > + * __pm_schedule_resume - Schedule run-time resume of given device. > > > > + * @dev: Device to resume. > > > > + * @autocancel: If set, the request will be cancelled during a resume from a > > > > + * system-wide sleep state if it happens before pm_autoresume() can be run. > > > > + */ > > > > > > Eeek! This is a bad idea. You never want to a resume to be cancelled. > > > > Sometimes I do (see above). > > Well no. A driver requests a resume because it has to. > This needs a defined call sequence. > > Do you guarantee that autoresume follows autosuspend or not? Not necessarily. If there's an autoresume request pending during STR or STD, the "sleep resume" will do very much the same thing as the autoresume, it will put the device into the full power state. IOW, the "sleep resume" can satisfy an autoresume request, so there should be a mechanism to cancel pending autoresume requests during 'sleep resume'. Still, it may be better if the driver's or bus type's ->resume() does that. > If not what sequences can happen? Obviously an autosuspended device > can be unplugged. > But the problem here is STR or STD. How do you notify drivers that the BIOS > has resumed their device instead of autoresume() being called? A driver > has to know that its device has become active without its knowledge. Actually, the driver will know what happens to the device anyway, because its ->resume() callback is going to be executed and it has to be synchronized with the ->auto[suspend|resume]() callbacks. > > > > + cancel_delayed_work_sync(&dev->power.suspend_work); > > > > > > That is the most glorious abuse of an API I've seen this year :-) > > > > Heh. > > > > OK, what would you do instead? > > A waitqueue. Or perhaps a completion? OK I tried to address the majority of your comments in the new version of the patch which I'm going to send in a while in a reply to an Alan's message. Best, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
