Re: [PATCH 02/07] dma: rework dw_dmac suspend_late()/resume_early()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Magnus Damm wrote:> On Fri, Jun 5, 2009 at 5:18 PM, Haavard> Skinnemoen<haavard.skinnemoen@xxxxxxxxx> wrote:> > Magnus Damm wrote:> >> +static struct dev_pm_ops dw_dev_pm_ops = {> >> +     .suspend_noirq = dw_suspend_noirq,> >> +     .resume_noirq = dw_resume_noirq,> >> +};> >> > Can this be const?> > Hm, adding const generates a warning for me. At on SuperH with> gcc-4.3.3 (Sourcery G++ Lite 4.3-143):> > [modified dev_pm_ops to const in sh_keysc.c]> >   CC      drivers/input/keyboard/sh_keysc.o> drivers/input/keyboard/sh_keysc.c:299: warning: initialization> discards qualifiers from pointer target type
Ok, it looks like the .pm field in struct device_driver is not const.Changing that will introduce lots of warnings elsewhere, so it'sprobably better to leave it alone.
So I guess the answer is no, it can't be const.
Haavard_______________________________________________linux-pm mailing listlinux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/linux-pm


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux