On Thursday 19 February 2009, Arve Hjønnevåg wrote: > On Tue, Feb 17, 2009 at 1:05 PM, Pavel Machek <pavel@xxxxxx> wrote: > > Hi! > > > >> The following patch series adds two apis, wakelock and earlysuspend. > >> The Android platform uses the earlysuspend api to turn the screen > >> and some input devices on and off. The wakelock code determines when > >> to enter the full suspend state. > > > > earlysuspend is an ugly hack and wakelock is very wrong name at the > > very least... as seen in previous discussion. Can we get that fixed? > > I don't have a fix for earlysuspend, but it is far less important than > wakelocks, so I can drop it from the patch series if that is > preferred. Well, I think it should be rethought at least. > Regarding the name, I don't agree with your statement that wakelock is > a very wrong name. Like I said before, you can view it as a > reader/writer lock where the readers protect the wake state of the > system. That said, if there is a better name that more than one person > can agree on, I can rename the api. Here is a list of suggestions I > have seen so far along with the api I think they dictate if the > existing functionality is to be preserved: > > wake_lock: > - api: wake_lock_init, wake_lock_destroy, wake_lock, wake_lock_timout, > wake_unlock > - pros: matches android user space api. > - cons: Can be confused with mutual exclusion apis. > > suspend_stop_valve: > - api: open/close? > - pros: ? > - cons: Api can be confused with device open/close. > > suspend_lock/sleep_lock: > - api: same as wakelock, but replace wake with suspend or sleep > - pros: Sleep or suspend is more easily associated with power > management than wake by some people. > - cons: Can be confused with mutual exclusion apis, (suspend_lock) was > confusing to people that also wrote android user space code. > > suspend_inhibitor: (from inhibit_suspend) > - api: suspend_inhibitor_init, suspend_inhibitor_destroy, > suspend_inhibit, suspend_inhibit_timeout, suspend_uninhibit > - pros: The effect is more obvious than *_lock. > - cons: Does not match android user space api (but less confusing than > suspend/sleep_lock). FWIW, I'd prefer the last one. The timeouted version still remains questionable, though. Thanks, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
