Hi Arve. On Tue, 2009-01-13 at 17:27 -0800, Arve Hjønnevåg wrote:> The following patch series adds two apis, wakelock and earlysuspend.> The Android platform uses the earlysuspend api to turn the screen> and some input devices on and off. The wakelock code determines when> to enter the full suspend state.> > These apis could also be useful to other platforms where the goal is> to enter full suspend whenever possible. A few general comments: Would you be able to provide some more documentation? In particular, I'mwondering what's 'early' about earlysuspend. It might also be good tosomething to Documentation/power explaining what the apis are, when/howthey're supposed to be used and such like. In the Kconfig files, I'm also missing the point to HAS_EARLYSUSPEND andHAS_WAKELOCK - they're bools that depends only on and WAKELOCKrespectively, so shouldn't you be able to just use the later symbols inifdefs? There are a few inlined #ifdefs (#ifdef CONFIG_WAKELOCK_STAT, eg) - theconvention as I understand it is to keep #ifdefs out of .c files as muchas possible, #ifdef'ing functions in header files instead. Regards, Nigel _______________________________________________linux-pm mailing listlinux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/linux-pm
