On Tue, 5 Aug 2008, Dasgupta, Romit wrote: > A minor change below: Removed old goto label PMError and introduced SysFSError. > Tested with CONFIG_PM, CONFIG_PM_SLEEP, without CONFIG_PM and ofcourse with CONFIG_USB_SUSPEND. Works fine. Strictly speaking, I suppose the statement label should be DPMSysfsError. On the other hand, the corresponding label for device_add_class_symlinks() is SymlinkError, not DeviceAddClassSymlinksError. The label for device_add_attrs() is AttrsError, not DeviceAddAttrsError. And the label for bus_add_device() is BusError, not BusAddDeviceError. Following those precedents, it seems appropriate that the label for dpm_sysfs_add() should be DPMError. I'll make the change and submit the patch. Alan Stern _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
