On Sat, 2008-08-02 at 00:53 +-0200, Rafael J. Wysocki wrote: +AD4 On Friday, 1 of August 2008, Matt Helsley wrote: +AD4 +AD4 +AD4 +AD4 On Fri, 2008-08-01 at 16:27 +-0200, Thomas Petazzoni wrote: +AD4 +AD4 +AD4 Hi, +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 Le Thu, 31 Jul 2008 22:07:01 -0700, +AD4 +AD4 +AD4 Matt Helsley +ADw-matthltc+AEA-us.ibm.com+AD4 a +AOk-crit : +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 --- a/kernel/Makefile +AD4 +AD4 +AD4 +AD4 +-+-+- b/kernel/Makefile +AD4 +AD4 +AD4 +AD4 +AEAAQA -5,7 +-5,7 +AEAAQA +AD4 +AD4 +AD4 +AD4 obj-y +AD0 sched.o fork.o exec+AF8-domain.o panic.o printk.o +AFw +AD4 +AD4 +AD4 +AD4 cpu.o exit.o itimer.o time.o softirq.o resource.o +AFw +AD4 +AD4 +AD4 +AD4 sysctl.o capability.o ptrace.o timer.o user.o +AFw +AD4 +AD4 +AD4 +AD4 - signal.o sys.o kmod.o workqueue.o pid.o +AFw +AD4 +AD4 +AD4 +AD4 +- signal.o sys.o kmod.o workqueue.o pid.o freezer.o +AFw +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 I have the impression that the code in kernel/power/process.c was +AD4 +AD4 +AD4 compiled only if CONFIG+AF8-PM+AF8-SLEEP was set. Now that the code has been +AD4 +AD4 +AD4 moved to kernel/freezer.c, it is unconditionnaly compiled in every +AD4 +AD4 +AD4 kernel. Is that correct ? +AD4 +AD4 +AD4 +AD4 +AD4 +AD4 If so, is it possible to put this new feature under some +AD4 +AD4 +AD4 CONFIG+AF8-SOMETHING option, for people who care about the kernel size ? +AD4 +AD4 +AD4 +AD4 How about making it depend on a combination of CONFIG variables? +AD4 +AD4 Here's an RFC PATCH. Completely untested. +AD4 +AD4 +AD4 +AD4 Signed-off-by: Matt Helsley +ADw-matthltc+AEA-us.ibm.com+AD4 +AD4 +AD4 Can you please also make the contents of include/linux/freezer.h depend on +AD4 CONFIG+AF8-FREEZER instead of CONFIG+AF8-PM+AF8-SLEEP? Good point -- I'll add that to this patch and repost. +AD4 Also, I'm not really sure if kernel/power/Kconfig is the right place to define +AD4 CONFIG+AF8-FREEZER. There's no nice place to put it since we're dealing with CONFIG+AF8 variables in two different Kconfig files. I put it in kernel/power/Kconfig because I wasn't certain Kbuild would do the right thing if I referenced PM+AF8-SLEEP from init/Kconfig. +AD4 Perhaps we should even move freezer.c from kernel/power to kernel It's already there. Perhaps you meant something else (kernel/power/process.c?)? +AD4 and define CONFIG+AF8-FREEZER in Kconfig in there. Andrew, what do you think? The Kconfig files in kernel/ are Kconfig.hz and Kconfig.preemt which don't seem appropriate. I suppose we could add another (perhaps Kconfig.cgroup). Thanks for the review+ACE Cheers, -Matt
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
