Re: [RFC PATCH 2/4] ACPI: introduce the mechanism to save/restore ACPI NVS memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> >  static int acpi_hibernation_begin(void)
> >  {
> >  	acpi_target_sleep_state = ACPI_STATE_S4;
> >  
> > -	return 0;
> > +	/* allocate pages for ACPI NVS memory before swsusp_shrink_memory */
> > +	return acpi_allocate_nvs_pages();
> 
> I think we shouldn't abort hibernation because of that.
> 
> This may be an emergency hibernation due to critical battery status and we
> surely don't want to about that.

I disagree here. If spec says 'you must save this', and we don't, we
are asking for subtle, dangerous, and very hard to repoduce problems.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux