On Wed, 2008-06-04 at 10:17 +0100, David Woodhouse wrote: > On Wed, 2008-06-04 at 11:10 +0200, Johannes Berg wrote: > > On Wed, 2008-06-04 at 09:59 +0100, David Woodhouse wrote: > > > On Wed, 2008-06-04 at 01:16 -0700, Andrew Morton wrote: > > > > We're going to want to be able to call printk_init() from modules. > > > > Please fix and test that, if we decide to proceed. > > > > > > Can we fix that by making it an alias for printk in the module case? > > > > > > The only reason we need it to be __init is so that we get the section > > > warnings when you use it from non-init code, right? Won't we get the > > > warning when non-init code refers to the string in initdata anyway? > > > > In fact, wasn't the warning Andy showed such a warning? > > Hm, yes it was. Why do we need __printk_init() to be anything other than > an alias for printk, then? It looks to me like we wouldn't need it at all, just the printk_init() macro that puts the format string into the right section. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
