On Monday, 12 of May 2008, Pavel Machek wrote:
> Hi!
>
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> >
> > The new suspend and hibernation callbacks introduced with
> > 'struct pm_ops' and 'struct pm_ext_ops' do not take a
> > pm_message_t argument, so the drivers using them will not be able
> > to use pci_choose_state() in its present form. For this reason,
> > introduce a new function, pci_choose_and_set_state(), playing the
> > role of pci_choose_state() combined with pci_set_power_state() and
> > allowing the driver to put the device into a power state chosen by
> > the platform.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > ---
> > drivers/pci/pci.c | 46 +++++++++++++++++++++++++++++++++++++++++++++-
> > include/linux/pci.h | 1 +
> > 2 files changed, 46 insertions(+), 1 deletion(-)
> >
> > Index: linux-2.6/drivers/pci/pci.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/pci/pci.c
> > +++ linux-2.6/drivers/pci/pci.c
> > @@ -509,7 +509,51 @@ pci_set_power_state(struct pci_dev *dev,
> > }
> >
> > pci_power_t (*platform_pci_choose_state)(struct pci_dev *dev);
> > -
> > +
> > +/**
> > + * pci_choose_and_set_state - Choose the power state of a PCI device and put
> > + * the device into that state.
> > + * @dev: PCI device to be put into a low power state
> > + * @state: State to put the device into by default
> > + *
> > + * Use the platform driver to choose the preferred PCI power state of given
> > + * device and put the device into that state. If the target power state of
> > + * the device cannot be chosen using the platform driver, the driver-provided
> > + * @state is used.
> > + *
> > + * RETURN VALUE:
> > + * -EINVAL if trying to enter a lower state than we're already in.
> > + * 0 if we're already in the requested state.
> > + * -EIO if device does not support PCI PM.
> > + * 0 if we can successfully change the power state.
> > + */
> > +
> > +int pci_choose_and_set_state(struct pci_dev *dev, pci_power_t state)
> > +{
>
> > + if (!pci_find_capability(dev, PCI_CAP_ID_PM))
> > + return -EIO;
>
> Hmm, not sure if this is good idea. First, simple drivers will just
> ignore the return value,
That doesn't matter to us.
> and second, it returns -EIO even if I'm
> asking it to enter state it already has -- like PCI_D0 -- no?
The -EIO means the operation could not be carried out, whatever the driver
author meant. In particular, we wouldn't check what the current state of the
device was, so why would we return anything other than error code?
Thanks,
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
