On Saturday, 10 of May 2008, Jesse Barnes wrote: > On Friday, May 09, 2008 2:44 pm Rafael J. Wysocki wrote: > > Okay, what about this: > > > > --- > > From: Rafael J. Wysocki <rjw@xxxxxxx> > > > > The new suspend and hibernation callbacks introduced with > > 'struct pm_ops' and 'struct pm_ext_ops' do not take a > > pm_message_t argument, so the drivers using them will not be able > > to use pci_choose_state() in its present form. For this reason, > > introduce a new function, pci_choose_and_set_state(), playing the > > role of pci_choose_state() combined with pci_set_power_state() and > > allowing the driver to put the device into a power state chosen by > > the platform. > > Yeah, that looks pretty good. The name is long but I can't think of a better > one offhand. Can you also update Documentation/power/pci.txt with the latest > best practices? I'm going to do that, eventually, but rather in a separate patch, when everything is ready for the new framework, while at the moment we still have some design work to do. For example, some drivers may want to call pci_enable_wake() for the target state and that must be done before pci_set_power_state() in case the target state is D3cold. To allow them to do that, we'll need a variant of pci_choose_and_set_state() with a 'wake_enabled' argument. > I wonder if we should do a pass through the drivers converting them to this > interface as well... Well, that would be lots of work and since we'd like the drivers to switch to the new framework entirely, we'll need to pass through them anyway for this purpose. I'd prefer that to be one pass. ;-) Thanks, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
