On Monday, 14 of April 2008, Benjamin Herrenschmidt wrote: > > On Mon, 2008-04-14 at 02:31 +0200, Rafael J. Wysocki wrote: > > > > Well, in our discussions with Alan Stern ->prepare() turned out to be necessary > > for exactly one reason, preventing new children of the device from being > > registered (by threads concurrent wrt the suspend thread). For this reason, > > it doesn't really seem a good idea to run it before the freezer (seemingly, it > > would be difficult to avoid situations in which the freezer would fail as a > > result of ->prepare()). > > I'm opposed to designing something around the freezer since we know it > will ultimately go away. Well, I think the freezer is not anything we can remove overnight. It's there and does something our users rely on, whether we like it or not. That means we have to provide the users with other things to rely on and _then_ remove the freezer, not the other way around. Hence, we need to design around it, otherwise the users will suffer. > If things like USB have issues with userland doing nasty things after > prepare(), then those things need to be fixed. The freezer will only > hide bugs and not even always or properly and not on all archs. > > > It looks like you'd like to have a third callback executed before the freezer, > > but OTOH I don't see the reason not to use a notifier for such things. > > That's just gratuituous complication imho. We can add callbacks every > week and no driver will every find out what to use and when. > > prepare() has quite well defined and nice semantics if you ignore your > freezer trickery. It matches well with the needs of things like > request_firmware or the DRM, and possibly a few others, in addition to > matching well the need to block bus discovery. > > If some drivers have issue because of what userland might do after > prepare(), then those drivers need to be fixed. We all know the freezer > is not a proper solution. It just hides problems and not always > correctly. > > > I have imagined that while we have the freezer, the operations that need to > > be carried out with the user space available will be done using notifiers > > and the rest will be done by ->prepare() and ->suspend(). Next, when we > > finally drop the freezer, it will be possible to move the code from the > > notifiers into ->prepare() and drop the notifiers altogether. > > Why do this two steps ? What is the point ? To avoid breaking things (from the functional point of view) unnecessarily. In short, I don't really see the difference between moving ->prepare() before the freezer and droppig the freezer, which I'm not going to do right now. Thanks, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
