On Monday, 4 of February 2008, Pavel Machek wrote: > On Mon 2008-02-04 00:20:14, Rafael J. Wysocki wrote: > > On Sunday, 3 of February 2008, Rafael J. Wysocki wrote: > > > On Sunday, 3 of February 2008, Pavel Machek wrote: > > > > Hi! > > > > > > > > > > This version works on 32-bit, and builds on 64-bit (but I'm pretty > > > > > > sure it does not work. 32-bit code probably needs to go into rm/....) > > > > > > > > > > > > > > > > Do you have an updated version or is this the latest one? > > > > > > > > I'm glad you ask ;-). Here's reasonably-recent version (I have > > > > slightly cleaner one, but it got obscured by 2.6.24-git merge), I > > > > eventually got it to work on 64-bit, by reusing trampoline.S code. > > > > > > I needed to rebase it against the current mainline (Makefile conflict). > > > > > > Some remarks: > > > > > > - It looks like arch/x86/kernel/acpi/wakeup.S is not necessary any more. > > > > > > - These warnings: > > > > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c: In function ???acpi_save_state_mem???: > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:41: warning: initialization makes pointer from integer without a cast > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:50: warning: format ???%d??? expects type ???int???, but argument 2 has type ???long unsigned int??? > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:50: warning: format ???%d??? expects type ???int???, but argument 3 has type ???long unsigned int??? > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:70: warning: ISO C90 forbids mixed declarations and code > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:82: warning: assignment makes integer from pointer without a cast > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:83: warning: assignment makes integer from pointer without a cast > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:84: warning: ISO C90 forbids mixed declarations and code > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:87: warning: ISO C90 forbids mixed declarations and code > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:90: warning: assignment makes integer from pointer without a cast > > > /home/rafael/src/linux-2.6/arch/x86/kernel/acpi/sleep.c:91: warning: ISO C90 forbids mixed declarations and code > > > > > > look pretty scary. > > > > Below is the arch/x86/kernel/acpi/sleep.c part without the warnings (untested). > > > > It still contains some hardcoded magic numbers and extern declarations, so > > I guess the #include list is not complete or another header is necessary. > > > > BTW: > > 1) why exactly is acpi_wakeup_address not (void *)? > > Well, it is physical address, not really a pointer. But then it's converted to a pointer all over the place (same for acpi_realmode). Using (void *) will cause it to have the appropriate size and to be type checked by the compiler in the C code. > > 2) header->level3_ident_pgt and header->level3_ident_pgt could be > (char *) IMO OK BTW, I don't like the way in which the 'struct wakeup_header' fields are reproduced in rm/wakeup.S very much, because it makes the code fragile. It might be better to define the offsets in asm-offsets*.c and refer to them relative to wakeup_header (if possible). Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
