Re: [PATCH] PM: invoke suspend notifications after console switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, 23 of January 2008, Rafael J. Wysocki wrote:
> On Friday, 11 of January 2008, Pavel Machek wrote:
> > On Thu 2008-01-10 14:14:36, Johannes Berg wrote:
> > > 
> > > On Mon, 2007-12-17 at 02:09 +0100, Johannes Berg wrote:
> > > > A subsequent patch will enable apm-emulation notification for suspends
> > > > triggered in any way by using the suspend notifications. This causes
> > > > the system to lock up between X being needed to switch away from the
> > > > VT and X already waiting for resume in the apm ioctl.
> > > > 
> > > > This patch moves the console switch (if enabled) before the suspend
> > > > notification (and after the resume notification) to avoid this issue.
> > > 
> > > I don't see this in the suspend git tree yet, anything wrong with it?
> > 
> > Its pretty intrusive I'd say.

How so?  There's only one user of the suspend notifiers right now, AFAICS.

> > And it is wrong; we'd prefer userspace 
> > to know what we are doing; if they are told we are suspending,
> > userspace may be able to do something more clever than long console
> > switch.

Well, we're not telling the userspace that we're suspending right now.

Also, the patch only reorders the console switch vs the suspend notifiers.
The console switch still happens before the freezer is run.

Thanks,
Rafael
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux