On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> From: Thomas Sujith <sujith.thomas@xxxxxxxxx>
>
> Intel menlow platform specific driver for thermal management.
>
> Signed-off-by: Thomas Sujith <sujith.thomas@xxxxxxxxx>
> Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> ---
> drivers/misc/Kconfig | 10
> drivers/misc/Makefile | 1
> drivers/misc/intel_menlow.c | 527 ++++++++++++++++++++++++++++++++++++++++++++
Why is this in drivers/misc? I don't have a thermal.h in mainline, but
if this is a new subsystem your adding care to create a directory under
drivers/ for it?
> +/*
> +* intel_menlow.c - Intel menlow Driver for thermal management extension
> +*
> +* Copyright (C) 2008 Intel Corp
> +* Copyright (C) 2008 Sujith Thomas <sujith.thomas@xxxxxxxxx>
> +* Copyright (C) 2008 Zhang Rui <rui.zhang@xxxxxxxxx>
Please add a whitespace before the * so they line up.
> +MODULE_AUTHOR("Thomas Sujith");
> +MODULE_AUTHOR("Zhang Rui");
I've never seen a driver with two MODULE_AUTHOR statements before. Does
this actually work? What does modinfo -F author say for your module?
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
