On Mon, 2007-12-17 at 07:03 +1100, Benjamin Herrenschmidt wrote: > On Sun, 2007-12-16 at 20:15 +0100, Rafael J. Wysocki wrote: > > > + * > > > + * Unfortunately we cannot do a timeout because then we'd > > > + * suspend again right away if the process that had apm_bios > > > + * open and that we timed out waiting for "acknowledges" the > > > + * event after we have resumed. If suspend doesn't work because > > > + * of a rogue process, just kill that process. > > > + * > > > + * FIXME: is the suspends_pending == 1 test racy? > > I think we can do the timeout thing easily... Just mark the fd's that > haven't ack'ed with a flag that makes us ignore the next ack... Yeah, except, is it really worth it? I should reword the comment into "I'm too lazy to do it" I guess, but you need CAP_SYS_ADMIN and you can always kill -9 the program that is making it wait. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
