Mark Gross wrote: > On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: >> On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: >> >>> The following is the qos_param patch that implements a genralization of >>> latency.c. >>> >> Just some general comments (as on irc): >> >> - use 'diffstat -p1 -w70' to summarize each patch >> - use checkpatch.pl to check for coding style and other buglets > > done > >> - has no API docs :( > not done yet. >> >> >> >>> +/* assumes qos_lock is held */ >>> +static void update_target(int i) >> I'd prefer a better arg name than 'i'. > > I do too, but i in this case is an Index. I think in many cases you could use a pointer to qos_array[i] instead of passing this index 'i' as a function argument. Roel _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm
