Re: Re: Possible problem with device_move()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 1 Aug 2007, Cornelia Huck wrote:

> On Tue, 31 Jul 2007 16:37:03 -0400 (EDT),
> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Still, I suppose it would be best to add a "move device A to the end of
> > the dpm_active list" routine for use in this sort of situation.  This 
> > should be easy to do.
> 
> Would it make sense if device_move() moved the new parent (and its
> parents) after the device in the dpm_active list automatically? Then we
> would only have to worry about reordering manually in very special
> cases.

As it stands right now, every place device_move() gets called is 
already special!

I'm afraid of reordering devices automatically; there's too much 
potential for creating new problems.  When a driver calls device_move() 
or does something similar, it should know what sort of list 
rearrangement is safe.  But the PM core can't be expected to know.

Alan Stern

_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux