On Thu 2007-07-12 00:10:43, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@xxxxxxx>
>
> The syncing of filesystems from within the freezer is generally not needed.
> Also, if there's an ext3 filesystem loopback-mounted from a FUSE one, the
> syncing results in writes to it and deadlocks. Similarly, it will deadlock if
> FUSE implements sync.
>
> Change freeze_processes() so that it doesn't execute sys_sync() and make the
> suspend and hibernation code paths sync filesystems independently of the
> freezer.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
ACK. Nice to see the fuse problem to disappear.
Pavel
> Index: linux-2.6.22-rc6-mm1/kernel/power/user.c
> ===================================================================
> --- linux-2.6.22-rc6-mm1.orig/kernel/power/user.c 2007-07-11 20:48:05.000000000 +0200
> +++ linux-2.6.22-rc6-mm1/kernel/power/user.c 2007-07-11 20:48:23.000000000 +0200
> @@ -153,6 +153,10 @@ static int snapshot_ioctl(struct inode *
> mutex_lock(&pm_mutex);
> error = pm_notifier_call_chain(PM_HIBERNATION_PREPARE);
> if (!error) {
> + printk("Syncing filesystems ... ");
> + sys_sync();
> + printk("done.\n");
> +
> error = freeze_processes();
> if (error)
> thaw_processes();
I see this is back-compatible, but can we do the sync in userspace,
instead?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-pm mailing list
linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/linux-pm
