On Monday 07 May 2007, Rafael J. Wysocki wrote: > On Monday, 7 May 2007 23:45, David Brownell wrote: > > On Monday 07 May 2007, Rafael J. Wysocki wrote: > > > On Monday, 7 May 2007 03:16, David Brownell wrote: > > > > > > So for now I have drivers/acpi/sleep/main.c exporting > > > > > > > > s_state = acpi_get_target_sleep_state(); > > > > > > > > so that ACPI-aware code can know to call "_S3D" instead of > > > > the "_S1D" or "_S4D" methods (and "_S3W" etc). Of course > > > > the $SUBJECT patch will finish borking that for S4. :( > > > > > > Why exactly? > > > > Because it adds new code paths ... currently pm_ops methods > > record the target state. Fixable later. > > Hmm, I think hibernation_ops do the equivalent of what pm_ops did for > ACPI_STATE_S4 and the target state is still recorded (in > acpi_enter_sleep_state_prep()). Isn't that correct? I didn't use that method, because of information hiding. See the patch I just posted. - Dave _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm