On Saturday, 5 May 2007 00:12, David Brownell wrote: > On Friday 04 May 2007, Rafael J. Wysocki wrote: > > On Friday, 4 May 2007 23:23, Johannes Berg wrote: > > > On Fri, 2007-05-04 at 23:11 +0200, Rafael J. Wysocki wrote: > > > > > > > Actually, prethaw is to prevent drivers loaded before the image is restored > > > > from doing unreasonable things. It doesn't have any effect on the drivers' > > > > .resume() routines. > > > > > > Oh, but it can, you could have a flag in your driver saying "the next > > > resume is after restore" and you set that flag in prethaw. > > > > No, you should have set that flag in .suspend(), really. :-) > > That doesn't work very well. Not only does suspend() not > know the target state, but you don't want to trash the > controller state if you're getting resumed after some kind > of fault in the suspend-to-disk path... > > I'm hoping that explains the smiley! Yes, among other things (like that passing anything from prethaw to .resume() really doesn't work unless the data are stored in a device ;-)). Greetings, Rafael _______________________________________________ linux-pm mailing list linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/linux-pm