Johannes Berg writes: > +_GLOBAL(power4_idle_irqs_softdisabled) > + li r6,1 > + b 0f > _GLOBAL(power4_idle) > + li r6,0 > +0: > BEGIN_FTR_SECTION > blr > END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP) > @@ -35,8 +40,8 @@ END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP) > rotldi r0,r0,16 > mtmsrd r0,1 /* hard-disable interrupts */ > li r0,1 > - stb r0,PACASOFTIRQEN(r13) /* we'll hard-enable shortly */ > - stb r0,PACAHARDIRQEN(r13) > + stb r0,PACAHARDIRQEN(r13) /* we'll hard-enable shortly */ > + stb r6,PACASOFTIRQEN(r13) /* set softirqs enabled bit */ Don't you have something backwards here? If we come in through power4_idle_irqs_softdisabled, the name would indicate to me that we want to end up with paca->soft_enabled set to 0, not 1. Paul.
