Pavel Machek wrote: > Hi! > > >> Recent patch from Rafael changed the order of platform_prepare() and >> swsusp_read(). platform_prepare() should happen before swsusp_read() >> in order to get nice LED blinking during load of the image and time for >> GPE activity to settle down. >> > > Well, looks acceptable to me. > > But if GPEs need some time to settle down, that should be done > explicitely, and with _big_ comment? What if your disk is too fast? > > Also, same problem is likely present in uswsusp (and harder to fix > there). Is this really required? > Pavel > ACPI interrupt gets disabled if the GPE activity is not disabled before switching to loaded image on some Acer machines. In most cases disabling them just before sw_switch() is enough, but it's better to be on a safe side. And don't forget about blinking LED :) Regards, Alex.