On Wed, Jan 24, 2007 at 11:51:17AM -0500, Alan Stern wrote:
> On Tue, 23 Jan 2007, Greg KH wrote:
>
> > On Tue, Jan 23, 2007 at 04:22:43PM -0800, David Brownell wrote:
> > > > > > static struct attribute *dev_attrs[] = {
> > > > > > + /* power management attributes */
> > > > > > + &dev_attr_autosuspend.attr,
> > > > >
> > > > > Belongs in /sys/devices/.../power/... then, right?
> > > >
> > > > No, I thought we want to drop that power/ directory.
> > >
> > > Dropping that directory hasn't AFAIK ever been discussed.
> > > If it were to be dropped, where would the per-device wakeup
> > > flags live?
> >
> > I don't know, it just really annoys me to see that power directory there
> > with no use for it for a lot of devices :)
>
> Would it help to add a flag somewhere in struct device (or struct
> dev_pm_info) for indicating that the device is not cognizant of PM? For
> instance, all those USB endpoint pseudo-devices we create -- it's a waste
> of time to try doing power management on them and it generates a bunch of
> useless and distracting warning messages in the system log.
Yes. In fact we should just make it a "has pm" type flag, as the
majority of devices do not.
So, what kind of devices do support these files? I can think of:
PCI
USB
and that's it right now. Do platform devices really use those files?
thanks,
greg k-h
