Hi, On Monday, 4 December 2006 20:44, Pavel Machek wrote: > Hi! > > > > > To solve first of these problems we need to stop using PF_FROZEN to tell > > > > tasks that they should go to the refrigerator. Instead, we can introduce > > > > a special TIF_*** flag and use it for this purpose, since it is allowed to > > > > change the other tasks' TIF_*** flags and there are special calls for it. > > > > > > > > To avoid the freeze_process()-refrigerator() race we can make freeze_process() > > > > to always check the task's PF_FROZEN flag after it's read its "freeze" flag. > > > > We should also make sure that refrigerator() will always reset the task's > > > > "freeze" flag after it's set PF_FROZEN for it. > > > > > > > > Signed-off-by: Rafael J. Wysocki <rjw at sisk.pl> > > > > > > ACK. > > > > But I think I'll need to add TIF_FROZEN for all architectures, because suspend > > to RAM is supposed to work on all of them, isn't it? > > Well, yes, it should be added, but no, I do not think s2ram works on > that many machines. So, do you think I should add any more architectures (which ones?) or leave it as is? > > Also, this patch is only sufficient with [1/2] or an alternative solution? > > I haven't finished looking at that one. I suspect it is okay, but I'm > not sure it is enough. Well, I think I haven't overlooked anything, but of course that's always possible. ;-) Greetings, Rafael -- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King
