| From: Pavel Machek<pavel at ucw.cz>
|
| Hi!
|
| > | > > > +static long
| > | > > > +get_vtg(const char *vdomain)
| > | > > > +{
| > | > > > + long ret = 0;
| > | > >
| > | > > Unnecessary initialisation.
| > | >
| > | > No, sorry.
| > |
| > | In get_vtg(), if VOLTAGE_FRAMEWORK is defined then
| > |
| > | ret = vtg_get_voltage(v);
| > |
| > | is the first user. If VOLTAGE_FRAMEWORK is not defined, the first user is:
| > |
| > | ret = vtg_get_voltage(&vhandle);
| > |
| > | Then "return ret;" follows. I cannot see a path where
| > | pre-initialisation of ret does anything useful. If someone removed the
| > | #else part, the compiler would bark.
| > ---
| >
| > True, but a good compiler should remove the dead initialization...
|
| True, but efficient code is only one of constraints. Code should be
| easy to read, too.
| Pavel
| --
| (english) http://www.livejournal.com/~pavelmachek
| (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[Ironically, I was going to say "I think this dead horse has been
sufficiently beaten, but then I saw the picture reference in Pavel's
signature and decided that would be rude!]
I agree - the initialization is unneeded. However, it's also mostly
harmless...
scott
--
scott preece
motorola mobile devices, il67, 1800 s. oak st., champaign, il 61820
e-mail: preece at motorola.com fax: +1-217-384-8550
phone: +1-217-384-8589 cell: +1-217-433-6114 pager: 2174336114 at vtext.com
