Hi!
> | Some nitpicking about the patch follows..
> |
> | On Sat, Sep 30, 2006 at 02:24:35AM +0400, Eugeny S. Mints wrote:
> | > +static long
> | > +get_vtg(const char *vdomain)
> | > +{
> | > + long ret = 0;
> |
> | Unnecessary initialisation.
>
> Many of us work in environments where initialization is in the coding
> standard.
Well, l-k is not _this_ kind of environment.
> | > +static int cpu_vltg_show(void *md_opt, int *value)
> | > +{
> | > + int rc = 0;
> | > + if (md_opt == NULL) {
> | > + if ((*value = get_vtg("v1")) <= 0)
> | > + return -EIO;
> | > + }
> | > + else {
> | > + struct pm_core_point *opt = (struct pm_core_point *)md_opt;
> | > + *value = opt->cpu_vltg;
> | > + }
> | > +
> | > + return rc;
> | > +}
> |
> | int rc is unnecessary because the function always returns 0. This
> | happens in many places.
> ---
>
> Wonder if he wrote it for a coding standard that requires single return
> (so that the "return -EIO" would have been "rc=-EIO") and converted
> it...
We sometimes do that in l-k, too. But having rc=-EIO; return rc; with
single return is little extreme. Just fix it, it is easier than
debating codingstyle.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
