On Sun, Oct 01, 2006 at 01:00:00AM -0400, Louis Garcia wrote: > On Sat, 2006-09-30 at 23:21 -0400, Dave Jones wrote: > > On Sat, Sep 30, 2006 at 10:49:42PM -0400, Louis Garcia wrote: > > > On Fri, 2006-09-29 at 15:55 -0700, Pallipadi, Venkatesh wrote: > > > > That's it.. This issue seems to be a side effect of that patch... > > > > > > > > Louis: After normal boot of 2.6.18, if you are not seeing the directory > > > > /sys/devices/system/cpu/cpu0/cpufreq > > > > > > > > Then try reverting this patch > > > > http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=c > > > > ommit;h=911cb74bb9e77e40749abc2fca6fe74d87d940f3 > > > > > > > > and then check whether the suspend resume issue goes away. > > > > > > I reverted this patch and my suspend issue is gone. Though the > > > directory /sys/devices/system/cpu/cpu0/cpufreq is non existent, with or > > > without this patch. > > > > Ok, I've backed that out in cpufreq.git, it'll go along to Linus soon. > > If you build acpi-cpufreq as a module, and you modprobe acpi-cpufreq, > > does it fail silently ? Or does it revert us back to the behaviour > > where it's noisy again? > > > > Dave > > I had not noticed it was not loaded. This maybe a bigger problem. With > the latest FC6 kernel this module gets loaded and thus suspend fails. I > rebuilt the same kernel but plopped this patch in. The module does not > want to load: > > # /sbin/modprobe acpi-cpufreq > FATAL: Error inserting acpi_cpufreq > (/lib/modules/2.6.18-1.2708.cpufreq/kernel/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.ko): No such device > > This is why suspend works. But now this module won't load. Right, what the STICKY patch that you reverted does is it silences the failure, by not unloading the module when it fails to init. What we want is the best of both worlds: Silence when its loaded and init fails, and no module around. Hmm. Dave
