On Wednesday 09 August 2006 13:53, Pavel Machek wrote: > On Wed 2006-08-09 13:36:16, Rafael J. Wysocki wrote: > > Hi, > > > > On Wednesday 09 August 2006 13:27, Pavel Machek wrote: > > > > > > Introduce the memory bitmap data structure and make swsusp use in the suspend > > > > > > phase. > > > > > > > > > > > > The current swsusp's internal data structure is not very efficient from the > > > > > > memory usage point of view, so it seems reasonable to replace it with a data > > > > > > structure that will require less memory, such as a pair of bitmaps. > > > > > > > > > > Well, 500 lines of code for what... 0.25% bigger image? > > > > BTW, that depends on the total size of RAM. On a 1.5 GB i386 box that would > > be something like 100%. > > Well, well, but 99.75% of that is from 3/5 patch, and we could still > get those 99.75% without bitmaps, right? Yes. I meant the total gain from all of the changes. [The highmem one would be quite difficult without bitmaps, I think, because the bitmaps give us the right ordering of pages automatically.] Rafael
