Hi! > >singleton wrote: > >>Here is a patch that implements a version of the > >>PowerOp concept. > > > >Any chance of breaking this up into logical patches > >that do one thing at > >a time so it can be reviewed better? > Here's powerop-core.patch, powerop-cpufreq.patch and > powerop-x86-centrino.patch. You failed to inline your patches, so I can't comment properly. Anyway, having talkative description strings 'suspend-to-disk ACPI' is ugly for kernel, and you got them wrong. I'm not sure if I read your patch right, but having suspend-to-disk latency measured in *micro*seconds seems 'interesting' to me. And what is the frequency of machine suspended to disk? Yes, making it easier to add states to /sys/power/state would be nice... Pavel
