David Brownell wrote:
> On Thursday 20 July 2006 12:50 pm, Eugeny S. Mints wrote:
>
>> +static int __init powerop_init(void)
>> +{
>> + return 0;
>> +}
>> +
>> +static void __exit powerop_exit(void)
>> +{
>> +}
>> +
>> +module_init(powerop_init);
>> +module_exit(powerop_exit);
>>
>
> Best to delete useless code like that. :)
>
> And you should be grabbing that mutex to register/unregister the arch
> methods table, otherwise there's little point in having it ...
>
basically agree. The reference code is handling only one arch layer
(essentially PM core) underneath PowerOP for the time being though.
At the same time PM Core is expected to be "aware" of all PM related
parameters and details so I actually would like to see an use case showing
when an extra layer below PowerOP may be useful to continue moving
towards multi arch layer approach.
Thanks,
Eugeny
