On Wed 2006-07-26 08:24:11, Nigel Cunningham wrote: > Hi. > > On Wednesday 26 July 2006 05:17, David Brownell wrote: > > On Tuesday 25 July 2006 11:29 am, Linus Torvalds wrote: > > > On Tue, 25 Jul 2006, David Brownell wrote: > > > > Hmm ... I just noticed that the swsusp code path (PM_SUSPEND_DISK) > > > > is ignoring the new suspend_prepare() mechanism. > > > > > > > > That doesn't seem like a good thing ... Linus, is there a reason you > > > > did it that way? > > > > > > Just because I found that neither interesting nor testable in my > > > environment. > > > > Yeah, testable is an issue. Maybe a better fix would be to remove > > the bus.suspend_prepare() operation for now. Someone with real use > > cases could easily add a complete working package that includes that > > mechanism plus some testable code that needs it. > > Not knowing anything about the actual details of the problem, I wonder if > these new calls would help with that acpi issue where it tries to allocate > memory with GFP_KERNEL during drivers suspend. Would it be helpful No, ACPI runs its code very early, and it can not be preallocated. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
