[linux-pm] memcpy() in swsusp (was: Re: [PATCH 2/2] Fix console handling during suspend/resume)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 06 July 2006 22:44, David Brownell wrote:
> 
> > > Of course it needs fixing ... it's a bug, also a regression.
> > > 
> > > My question is where to fix...
> > 
> > Well, I meant replacing the memcpy() in copy_data_pages with an open coded
> > copying loop.  That should be enough to fix the problem.
> 
> One like this?  Yes, it works.

Heh, I've just sent my own version. ;-)

> The slower speed shouldn't be much of an issue here.

Yup.  On my system it's hardly noticeable.

> (Though I'm glad that something in RC1 has gotten rid of that slowdown in
> reading/writing snapshots.)

Er, that's nothing in swsusp AFAICT.  (Or maybe the default value of image_size
is now different.  Anyway you can change it using /sys/power/image_size.)

Rafael


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux