On Wed, Jun 28, 2006 at 08:24:29PM -0700, Linus Torvalds wrote: > > > On Wed, 28 Jun 2006, Greg KH wrote: > > > > Any thoughts as to applying your patch to the tree or not? No objection > > from me if you want to. > > I've not actually had anybody report any testing success from it, and > since I don't use suspend-to-disk, for example, if would be good to have > verification. I'll try this out and let you know how it goes. > AS FAR AS I CAN TELL the patch won't actually change any behaviour (I have > actually been running for the last few days with the separate patch that > _does_ do that - moves the PCI config suspend/resume to the late/early > rsume phase), but hey, mistakes happen. > > Anyway, this is the current patch (rebased to current git, and with the > same "list_move[_tail]()" cleanups that mainline got independently). Does > anybody see any remaining problems in it? And can somebody who runs > suspend-to-disk verify that that still works (I don't see why it wouldn't, > but still..) > > Oh, and this has the "class suspend" example that may not be how you > actually did it. I didn't implement the class suspend stuff yet, I was working to get the core to be able to handle it properly for real devices (like network ones), instead of just "fake" ones like usb endpoints :) In reading it over, it looks fine to me, time to go test... thanks, greg k-h