On Tuesday 30 May 2006 12:11 pm, Pavel Machek wrote: > Hi! > > > Small driver suspend() updates in preparation for the upcoming FREEZE message; > > > > - Only compare message events for equality against PM_EVENT_* codes; > > not against integers, or using greater/less-than comparisons. > > (PM_EVENT_* should really become a __bitwise thing.) > > > > - Explicitly test for SUSPEND events (rather than not-something-else) > > before suspending devices. > > > > - Removes more of the confusion between a pm_message_t (wraps event code) > > and a "state" ... suspend() originally took a target system state. > > > > These updates are correct and appropriate even without new PM_EVENT codes. > > --- > > drivers/ide/ppc/pmac.c | 14 ++++++++------ > > drivers/media/dvb/cinergyT2/cinergyT2.c | 2 +- > > drivers/scsi/libata-core.c | 6 +++--- > > drivers/scsi/mesh.c | 7 ++++--- > > 4 files changed, 16 insertions(+), 13 deletions(-) > > ACK. (You probably want to add s-o-b: header, and not send changelog > twice.) I'll forward this to Andrew for 2.6.18 then ... was holding off on the signed-off-by pending feedback. Changelog sent twice to make sure that the linux-pm archives are readable. :) - Dave
