On Friday, 13 January 2006 21:59, Pavel Machek wrote: > On Pá 13-01-06 21:49:38, Rafael J. Wysocki wrote: > > On Friday, 13 January 2006 20:53, Ingo Oeser wrote: > > > On Friday 13 January 2006 00:31, Rafael J. Wysocki wrote: > > > > On Thursday, 12 January 2006 23:09, Pavel Machek wrote: > > > > > > +SNAPSHOT_IOCAVAIL_SWAP - check the amount of available swap (the last argument > > > > > > + should be a pointer to an unsigned int variable that will contain > > > > > > + the result if the call is successful) > > > > > > > > > > Is this good idea? It will overflow on 32-bit systems. Ammount of > > > > > available swap can be >4GB. [Or maybe it is in something else than > > > > > bytes, then you need to specify it.] > > > > > > > > It returns the number of pages. Well, it should be written explicitly, > > > > so I'll fix that. > > > > > > Please always talk to the kernel in bytes. Pagesize is only a kernel > > > internal unit. Sth. like off64_t is fine. > > > > These are values returned by the kernel, actually. Of course I can convert them > > to bytes before sending to the user space, if that's preferrable. > > > > Pavel, what do you think? > > Bytes, I'd say. It would be nice if preffered image size was in bytes, > too, for consistency. OK Rafael
