Hi! > As part of the infrastructure changes, we could remove > dev->power.power_state, dev->power.prev_state, and maybe also > dev->power.saved_state (currently it is used only in a few platform > drivers for stuff that could easily be stored in a private data > structure). Nothing would be needed but the name pointer, and that should > be under the bus/driver's control. > > People have already pretty much agreed that ->resume needs to take a > pm_message_t argument, and that will mean changing a lot of drivers. We > ought to settle on a decision about the rest of this too, so we won't have > to go through and change them all yet again. I think they need to go in one-after-one, anyway... Adding parameter to resume() should definitely be separate patch, because it needs to change all drivers *at once*. Removing power_state usage can be done incrementally... Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms