[linux-pm] RTPM allowing trailing newline in state_store()

[dgollub at suse.de (Daniel Gollub)]

hi,

is there a special way reserved for writing on power/state in the device
directories?
a simple echo {0,1,2,3} doesn't work, because of the trailing newline.
only with echo -n it works.
i was very confused about that... i needed two days to figure this out
:)
maybe it's a good idea to allow an value with \n  .. because other state
files like /sys/power/state also allows trailing newlines.

can you please give me a hint, if there is another special way to set a
single device in suspend. or is there a reason for ignoring trailing
newline?

thanks,
daniel

simple patch for allowing trailing newlines in state_strore in sysfs.c :

--- linux/drivers/base/power/sysfs.c.orig       2005-09-20
17:07:42.000000000 +0200
+++ linux/drivers/base/power/sysfs.c    2005-09-20 17:09:42.000000000
+0200
@@ -36,7 +36,7 @@ static ssize_t state_store(struct device
        int error = 0;
 
        state = simple_strtoul(buf, &rest, 10);
-       if (*rest)
+       if (*rest && *rest != '\n')
                return -EINVAL;
        if (state)
                error = dpm_runtime_suspend(dev, state);