On Thu, 2005-04-28 at 13:49, Nigel Cunningham wrote: > > > Do you have a particular example in mind? I haven't seen or heard > of > > > any > > > freezing failures in Suspend2 for ages, so I'm struggling to see > what > > > is > > > lacking. > > No, actually. Maybe I should send the proposal till I really find a > case > > :). I only noticed the syslogd case. Somebody reported the > > 'mdnsresponder' process case, but didn't look at it yet. > > http://bugme.osdl.org/show_bug.cgi?id=3964 > > Ah. Ok. The ipw2100 driver starts a workqueue. Since I also have > patches > to make kthreads freezable, we sometimes have to tell people to add an > extra parameter to the create_workqueue call. Once that's done, I > believe it all works fine. > > I keep saying I must seek to merge these patches. I've gotten caught > up > on trying to get everything ready to merge at once, and confused by > what > Pavel is and isn't changing :> Pavel, since you're cc'd I might as > well > ask, am I still right to submit those patches again? If so, I'll try > to > do it this evening. > > On a related topic, I've tried to get hotplug cpu support working with > suspending, but it looks like more is needed. In particular, the > 'dead' > cpu still needs state saved and restored, so we're not really gaining > anything with the current implementation. If hotplug really killed the > CPU and rebooted it, the story might be different. What states should be saved/restored for the dead CPU? The dead CPU is in idle thread before becoming dead, so ingoring save/restore general registers doesn't matter. Sure there are something which must be saved/restored, like the MTRR registers and possible Local APIC registers if their value are different with the boot time. But there are no much such cases, I think. Thanks, Shaohua
