[linux-pm] Re: freeze_processes questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!
> 
> I have two questions regarding freeze_processes():
> 
> 1) Shouldn't we take the TASK_UNINTERRUPTIBLE state into consideration?  Now
> we will fail if a process is sleeping when we try to freeze it.

We can't allow processes to sleep at arbitrary places. Therefore we
send UNINTERRUPTIBLE task a signal, and hope it can get into
refrigerator in time.

> 2) Is it necessary to check p->state == TASK_STOPPED and
> p->state == TASK_TRACED twice in a row (once in freezable() and
> then again in the next if ())?

Those tests should probably be killed from if() below. As far as I can
see, they can not trigger there.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux