Hi. On Fri, 2005-04-01 at 08:18, Pavel Machek wrote: > Hi! > > > > > Ok, what do you think about this one? > > > > > > > > =================================================================== > > > > > > > > swsusp: disable usermodehelper after generating memory snapshot and > > > > before resuming devices, so when device fails to resume we > > > > won't try to call hotplug - userspace stopped anyway. > > > > > > Hm, shouldn't we disable it before we start to freeze processes? We don't > > > want any more processes trying to start up after we've taken care of > > > them.. > > > > > > > Can't a device be removed (for any reason) _while_ we are freezing > > processes? I think freeszing code will properly deal with it... What > > about suspend semantics - if suspend fails do we say the device should > > be operational or the system should attempt to re-initialize? I.e. we > > are not doing suspend after all - can we still drop messages on the > > floor? After all, we still have ability to run coldplug after failed > > suspend. > > I believe we should freeze hotplug before processes. Dropping messages > on the floor should not be a problem, we should just call coldplug > after failed suspend. How will you know which devices to call coldplug for, post resume? (Or does it figure that out itself somehow?) Regards, Nigel -- Nigel Cunningham Software Engineer, Canberra, Australia http://www.cyclades.com Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028; Mob: +61 (417) 100 574 Maintainer of Suspend2 Kernel Patches http://suspend2.net
