[cc list snipped ] On Fri, 25 Mar 2005, Pavel Machek wrote: > Hi! > > pm_message_t is becoming typedefed into struct with single field, > "event" real soon now. If you do anything that wants to look inside > pm_message_t, please base it on this patch. > > [Patrick and David would like to pass struct pm_message * instead of > pm_message_t, but that just does not fly. Original code passed u32 > there (ouch), and it is not easy to replace u32 with struct pm_message > * and not breaking the whole tree. Plus you do not get enough > typechecking that way.] There is significant disagreement about the interface that this patch proposes from a number of people. About 12 hours ago, Pavel agreed that he would not try to push this patch upstream until others had a chance to come up with an alternative, more palatable interface. That seems to be in direct conflict with this email. Pavel, please think about the situation. Just because you think something is a good idea and want the patch to go in doesn't mean that everyone else does. You must accept the fact that people will disagree with you and that some people may want an alternative interface. I am willing to work with you, and I even volunteered to audit and fix up all of the drivers. But, undermining that effort by back-peddling on what you said and posting a patch in direct conflict with earlier agreement borders on dishonesty and is frankly quite rude. Saying 1 thing and doing another is counter-productive. It prolongs the development process and brings to the arena feelings of frustration and futility. Ideally, we should all try to minimize those, both in ourselves and in each other. There have been a lot of egos flying on this list. Everyone has an idea of exactly how things should be done, and many people seem to imply that they cannot be wrong. Even though you may not be thinking that, it may very well come across that way. I've been guilty of it in the past, but I've been making a very concerted effort to NOT be so arrogant, to come to terms with and understand everything that people are saying, as well as get back into being a full-time kernel developer. We've been doing this for too long to have the flamewars burn out the motivation once again. We have things to gain from listening to and working with each other. Please, let's get this done. Thanks, Pat
