> > Your snipped (please, inline, don't attach) > > I use what reliably gets through mailers; no apologies! Which is also what reliably gets rejected by Linus :) It's common practice to request people to inline patches in email, and fix their mailers if they scramble them :) The main issue when discussing like that is that you can't "quote" an attachement when replying. > > would mean D2 is to be > > preferred over D3 at all times ? > > Only for standby and STR. If the driver has > particular opinions -- say, it knows that after > D3 a firmware reload is needed, AND that it can > somehow guarantee D2 is supported (rarely an option > for USB HCDs or other class drivers) -- it can > apply whatever policy it likes, and won't use that > routine in its pci suspend() entry. > > But otherwise, it can at least guarantee that > the controller enters some plausible low power > state. S1 uses D1 if possible, else D3hot; > S2 uses D2 if possible, else D3hot. Oh, and > all those "legacy" controllers without PCI PM > support -- they stay in D0 (no choice). > > Thing is, D3hot is always supported given PCI PM. > D2 isn't, unless maybe you're talking about some > particular chips instead of generic code. > > - Dave > -- Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
