[linux-pm] type-checking for driver model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 29, 2004 at 01:21:02PM +0200, Pavel Machek wrote:
> +typedef u32 __bitwise pm_message_t;

Ugh, I hate typedefs.  You can just do this with an enum if you want,
but I saw Linus's post too, so I understand why you did it this way.

> +#define PMSG_APM_SUSPEND	((__force pm_message_t) 3)
> +#define PMSG_APM_STANDBY	((__force pm_message_t) 3)
> +#define PMSG_SYSTEM_HALT	((__force pm_message_t) 3)
> +#define PMSG_SYSTEM_REBOOT	((__force pm_message_t) 3)
> +#define PMSG_SYSTEM_SHUTDOWN	((__force pm_message_t) 3)
> +#define PMSG_SUSPEND_RAM	((__force pm_message_t) 3)
> +#define PMSG_SUSPEND_DISK	((__force pm_message_t) 3)
> +#define PMSG_DEV_DETACH	((__force pm_message_t) 3)

Are you sure these are all supposed to be the same value?

thanks,

greg k-h


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux