From: Christoph Hellwig > Sent: 29 September 2020 11:29 ... > You can't call remap_pfn_range on memory returned from > dma_alloc_coherent (which btw is not marked uncached on many platforms). > > You need to use the dma_mmap_coherent helper instead. Hmmmm. I've a driver that does that. Fortunately it only has to work on x86 where it doesn't matter. However I can't easily convert it. The 'problem' is that the mmap() request can cover multiple dma buffers and need not start at the beginning of one. Basically we have a PCIe card that has an inbuilt iommu to convert internal 32bit addresses to 64bit PCIe ones. This has 512 16kB pages. So we do a number of dma_alloc_coherent() for 16k blocks. The user process then does an mmap() for part of the buffer. This request is 4k aligned so we do multiple remap_pfn_range() calls to map the disjoint physical (and kernel virtual) buffers into contiguous user memory. So both ends see contiguous addresses even though the physical addresses are non-contiguous. I guess I could modify the vm_start address and then restore it at the end. I found this big discussion: https://lore.kernel.org/patchwork/patch/351245/ about these functions. The bit about VIPT caches is problematic. I don't think you can change the kernel address during mmap. What you need to do is defer allocating the user address until you know the kernel address. Otherwise you get into problems is you try to mmap the same memory into two processes. This is a general problem even for mmap() of files. ISTR SYSV on some sparc systems having to use uncached maps. If you might want to mmap two kernel buffers (dma or not) into adjacent user addresses then you need some way of allocating the second buffer to follow the first one in the VIVT cache. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
