RE: [PATCH V2 1/4] misc: vop: change the way of allocating vring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH V2 1/4] misc: vop: change the way of allocating vring
From: Sherry Sun <sherry.sun@xxxxxxx>
Date: Tue, 29 Sep 2020 13:02:15 +0000
Cc: "sudeep.dutt@xxxxxxxxx" <sudeep.dutt@xxxxxxxxx>, "ashutosh.dixit@xxxxxxxxx" <ashutosh.dixit@xxxxxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>, "kishon@xxxxxx" <kishon@xxxxxx>, "lorenzo.pieralisi@xxxxxxx" <lorenzo.pieralisi@xxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, dl-linux-imx <linux-imx@xxxxxxx>
In-reply-to: <20200929102333.GA7784@infradead.org>
References: <20200929084425.24052-1-sherry.sun@nxp.com> <20200929084425.24052-2-sherry.sun@nxp.com> <20200929102333.GA7784@infradead.org>

Hi Christoph,

> 
> > +		vr->va = dma_alloc_coherent(vop_dev(vdev), vr_size,
> &vr_addr,
> > +GFP_KERNEL);
> 
> Please stick to 80 character lines unless you have a really good reason not to.

Okay, will change it in V3.

Regards
Sherry

References:
- [PATCH V2 0/4] Change vring space from nomal memory to dma coherent memory
  - From: Sherry Sun
- [PATCH V2 1/4] misc: vop: change the way of allocating vring
  - From: Sherry Sun
- Re: [PATCH V2 1/4] misc: vop: change the way of allocating vring
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH] Use maximum latency when determining L1/L0s ASPM v2
Next by Date: RE: [PATCH V2 2/4] misc: vop: do not allocate and reassign the used ring
Previous by thread: Re: [PATCH V2 1/4] misc: vop: change the way of allocating vring
Next by thread: [PATCH V2 2/4] misc: vop: do not allocate and reassign the used ring
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]