On Tue, Sep 29, 2020 at 05:38:00PM +0800, Ethan Zhao wrote: > On Tue, Sep 29, 2020 at 4:51 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 29, 2020 at 10:35:14AM +0800, Ethan Zhao wrote: > > > Preferred style, there will be cleared comment in v6. > > > > Avoid top postings. > > > > > On Sat, Sep 26, 2020 at 12:42 AM Andy Shevchenko > > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > On Thu, Sep 24, 2020 at 10:34:21PM -0400, Ethan Zhao wrote: ... > > > > > Buffer I/O error on dev nvme0n1p1, logical block 468843328, > > > > > async page read > > > > > BUG: kernel NULL pointer dereference, address: 0000000000000050 > > > > > #PF: supervisor read access in kernel mode > > > > > #PF: error_code(0x0000) - not-present page > > > > > > > > Same comment about Oops. > > > > In another thread it was a good advice to move the full Oops (if you think it's > > very useful to have) after the cutter '---' line, so it will be in email > > archives but Git history. > > So git history wouldn't give any of the Oops context, and he/she has > to access LKML, > if offline, then ...lost. Tell me, do you really think the line: #PF: error_code(0x0000) - not-present page makes any sense in the commit message? I do not think so. And so on, for almost 60% of the Oops. Really, to help one person you will make millions suffering. It's not okay. -- With Best Regards, Andy Shevchenko
