Hi Christoph, Thanks for your valuable feedback as always On Mon, 2020-09-28 at 08:17 +0100, Christoph Hellwig wrote: > Please keep this code in VMD if we really have to do it (although I'd > be perfectly fine to let people dumb enough to enable VMD devices to > live with the problems). Great! Sounds like you're more open to us working openly within vmd.c then? > You are adding lots of code that gets > copiled into every Linux kernel that supports PCI jut to work around > a copletely idiotic invention from Intel that makes life painful for > us for no good reason. Well this fix in particular may not be needed once the dynamic hotplug resource resizing set is in and build on that. But frankly the generic resource assignment code itself is very difficult to work within and has been discussed at several LPC over the years. I don't see a problem with another algorithm which could be relied upon by other host bridge controller drivers if they want it. I also spent a good deal of time trying to get the minimizing algorithm into pci_assign_unassigned_root_bus_resources, where the only instance of pci=realloc detection takes place (who knew there were so many originating different paths for resource assignment?). I couldn't make headway there so started fresh. Maybe someone talented could refactor mine into it and save a few instruction bytes.
